[SPARK-29504][WebUI] Toggle full job description on click#26222
[SPARK-29504][WebUI] Toggle full job description on click#26222PavithraRamachandran wants to merge 2 commits intoapache:masterfrom
Conversation
| $(".description-input").dblclick(function() { | ||
| $(this).removeClass("description-input").addClass("description-input-full"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We supported this feature before. https://github.com/apache/spark/pull/25374/files#diff-c794386db0ef43c8090b67c83cf6b950L81-L89
There was a problem hiding this comment.
@wangyum yes. It was present. But
https://github.com/apache/spark/pull/25374/files
removed additonal-metrics.js whch had the function for this double click event.
So this feature was broken.
There was a problem hiding this comment.
Could you update your changes to
$(function() {
// Show/hide full job description on click event.
$(".description-input").click(function() {
$(this).toggleClass("description-input-full");
});
});There was a problem hiding this comment.
@wangyum i have changed. could you check
|
ok to test |
|
Test build #112540 has finished for PR 26222 at commit
|
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks reasonable if it restores previous functionality
|
@PavithraRamachandran I took a quick try with the code changes in this PR and it doesn't work. Could you double confirm that? Also, I think the PR title and description should be updated. For the |
|
@gengliangwang i rebuilt in my local setup and tested again. Its working .i rechecked |
PavithraRamachandran
changed the title
|
@PavithraRamachandran Sorry my browser loaded the cached script. I try |
gengliangwang
changed the title
|
@PavithraRamachandran I have updated the PR title and description for you. |
|
@gengliangwang thank you . Could you merge? |
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
Thanks, merging to master
|
@PavithraRamachandran sorry I think the fix should be ported into branch-2.4 as well, since the regression exists in branch-2.4 #25484 |
On clicking job description in jobs page, the description was not shown fully. Add the function for the click event on description. when there is a long description of a job, it cannot be seen fully in the UI. The feature was added in apache#24145 But it is missed after apache#25374 Before change:  After change: on Double click over decription  No Manually test Closes apache#26222 from PavithraRamachandran/jobs_description_tooltip. Authored-by: Pavithra Ramachandran <pavi.rams@gmail.com> Signed-off-by: Gengliang Wang <gengliang.wang@databricks.com>
6 participants
What changes were proposed in this pull request?
On clicking job description in jobs page, the description was not shown fully.
Add the function for the click event on description.
Why are the changes needed?
when there is a long description of a job, it cannot be seen fully in the UI.
The feature was added in #24145
But it is missed after #25374
Before change:
After change: on Double click over decription
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually test